extract permission mask comparison for subclasses to override #5908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwinch
requested changes
Oct 3, 2018
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please see inline comments.
| * @param p the Permission we are checking against. | ||
| * @return true, if the respective masks are considered to be equal. | ||
| */ | ||
| protected boolean comparePermissionMasks(AccessControlEntry ace, Permission p) { |
Member
There was a problem hiding this comment.
This method is very implementation specific and would not make sense if a user decides to change the strategy. Please rename to isGranted.
Member
There was a problem hiding this comment.
Please add a test to demonstrate overriding this method works
rwinch
approved these changes
Oct 3, 2018
rwinch
added
in: core
Member
|
Moved to 5.2.x since it is an enhancement |
Contributor
|
Thanks for the PR @Metavirulent! This is now merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEC-2342
Extracts the mask comparison in DefaultPermissionGrantingStrategy into a protected method.
This allows overriding the default behavior in a subclass without having to copy the whole isGranted() method.
As discussed in the above issue (and others like SEC-1140), users can choose to implement a different strategy, e.g. do a bitwise mask comparison instead of the integer comparison.